Messages in this thread | | | Date | Wed, 14 Dec 2011 00:03:03 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files v2 |
| |
On Tue, 13 Dec 2011, Andi Kleen wrote:
> > Hi Andi, is it possible to do say kstrdup or something instead of > > It's possible, just would add complexity with an additional > error path. > > > variable-size array in fn[strlen(name) + 1] ? As far as I remember > > we already had some warnings with them at least in perf land (or > > trace land). Or I miss something? > > Not aware of any problems with tracing or perf. I like them at least.
That does not make them better. We had wreckage before and you can just consult commit a84a79e4d3 and then find a good explanation why your usage is safe.
Thanks,
tglx
| |