Messages in this thread | | | Date | Tue, 13 Dec 2011 15:38:17 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/1] scsi: retrieve cache mode using ATA_16 if normal routine fails |
| |
On 12/13/2011 03:53 AM, James Bottomley wrote: > On Tue, 2011-12-13 at 09:20 +0900, Namjae Jeon wrote: >>> This whole patch looks like a layering violation. Why not just update >>> the SAT layer to translate the MODE SENSE correctly? >> Would plz you explain more ? I didn't clearly understand your point yet. > > The ATA layer does translation for SCSI commands. Just translate the > mode sense correctly to use IDENTIFY word 85. It's a smaller patch and > no need for any changes in SCSI.
Correct.
> Actually, looking at it, it seems to be correct ... why is it not > working for you?
Indeed -- the patch attempts to address a problem that the libata-scsi translation module already handles.
I would look at why the device is not properly reporting that already. If necessary, we would update libata not SCSI.
Jeff
| |