lkml.org 
[lkml]   [2011]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: ISP1760: Add flags for interrupt polarity and edge/level trigger
On Tue, Dec 13, 2011 at 10:33:13AM +0100, Alexander Stein wrote:
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> drivers/usb/host/isp1760-if.c | 4 ++++
> include/linux/usb/isp1760.h | 2 ++
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
> index a7dc1e1..0ef9867 100644
> --- a/drivers/usb/host/isp1760-if.c
> +++ b/drivers/usb/host/isp1760-if.c
> @@ -388,6 +388,10 @@ static int __devinit isp1760_plat_probe(struct platform_device *pdev)
> devflags |= ISP1760_FLAG_DACK_POL_HIGH;
> if (priv->dreq_polarity_high)
> devflags |= ISP1760_FLAG_DREQ_POL_HIGH;
> + if (priv->interrupt_polarity_high)
> + devflags |= ISP1760_FLAG_INTR_POL_HIGH;
> + if (priv->interrupt_edge_triggered)
> + devflags |= ISP1760_FLAG_INTR_EDGE_TRIG;
> }
>
> hcd = isp1760_register(mem_res->start, mem_size, irq_res->start,
> diff --git a/include/linux/usb/isp1760.h b/include/linux/usb/isp1760.h
> index de7de53..c5edbc8 100644
> --- a/include/linux/usb/isp1760.h
> +++ b/include/linux/usb/isp1760.h
> @@ -13,6 +13,8 @@ struct isp1760_platform_data {
> unsigned analog_oc:1; /* Analog overcurrent */
> unsigned dack_polarity_high:1; /* DACK active high */
> unsigned dreq_polarity_high:1; /* DREQ active high */
> + unsigned interrupt_polarity_high:1;
> + unsigned interrupt_edge_triggered:1;

So you added these, and you check them, but who sets them? What is the
point of this patch at this point in time?

confused,

greg k-h


\
 
 \ /
  Last update: 2011-12-13 19:03    [W:0.041 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site