lkml.org 
[lkml]   [2011]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] mfd: omap-usb-host: Use gpio_request_one
    Hi Axel,

    On 12/01/11 03:53, Axel Lin wrote:
    > Use gpio_request_one() instead of multiple gpiolib calls.
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>
    > ---
    > drivers/mfd/omap-usb-host.c | 20 +++++++-------------
    > 1 files changed, 7 insertions(+), 13 deletions(-)
    >
    > diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
    > index 86e1458..6533ecc 100644
    > --- a/drivers/mfd/omap-usb-host.c
    > +++ b/drivers/mfd/omap-usb-host.c
    > @@ -715,19 +715,13 @@ static int usbhs_enable(struct device *dev)
    > clk_enable(omap->usbtll_ick);
    >
    > if (pdata->ehci_data->phy_reset) {
    > - if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0])) {
    > - gpio_request(pdata->ehci_data->reset_gpio_port[0],
    > - "USB1 PHY reset");
    > - gpio_direction_output
    > - (pdata->ehci_data->reset_gpio_port[0], 0);
    > - }
    > + if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
    > + gpio_request_one(pdata->ehci_data->reset_gpio_port[0],
    > + GPIOF_OUT_INIT_LOW, "USB1 PHY reset");
    >
    > - if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
    > - gpio_request(pdata->ehci_data->reset_gpio_port[1],
    > - "USB2 PHY reset");
    > - gpio_direction_output
    > - (pdata->ehci_data->reset_gpio_port[1], 0);
    > - }
    > + if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
    > + gpio_request_one(pdata->ehci_data->reset_gpio_port[1],
    > + GPIOF_OUT_INIT_LOW, "USB2 PHY reset");

    I was wondering, if we need the gpio_is_valid() check here and above?
    gpio_request() already does the gpio_is_valid() check,
    so why should we double check?


    --
    Regards,
    Igor.


    \
     
     \ /
      Last update: 2011-12-01 09:05    [W:8.308 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site