lkml.org 
[lkml]   [2011]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] staging: vt6656: datarate.c: Remove unneeded comments
On Thu, Dec 01, 2011 at 12:31:57AM +0000, Marcos Paulo de Souza wrote:
> - // clear statistic counter for auto_rate
> - for (ii = 0; ii <= MAX_RATE; ii++) {
> - psNodeDBTable->uTxOk[ii] = 0;
> - psNodeDBTable->uTxFail[ii] = 0;
> - }
> + /* clear statistic counter for auto_rate */
> + for (ii = 0; ii <= MAX_RATE; ii++)
> + psNodeDBTable->uTxOk[ii] = psNodeDBTable->uTxFail[ii] = 0;
> }
>

Don't do that... Better to have the assignments on separate lines.

If you wanted, you could use memset and get rid of the loop.

void s_vResetCounter(PKnownNodeDB psNodeDBTable)
{
memset(psNodeDBTable->uTxOk, 0, sizeof(psNodeDBTable->uTxOk));
memset(psNodeDBTable->uTxFail, 0, sizeof(psNodeDBTable->uTxFail));
}

regards,
dan carpenter
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-12-01 16:13    [W:0.819 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site