lkml.org 
[lkml]   [2011]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[255/264] md/raid5: STRIPE_ACTIVE has lock semantics, add barriers
    3.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Williams <dan.j.williams@intel.com>

    commit 257a4b42af7586fab4eaec7f04e6896b86551843 upstream.

    All updates that occur under STRIPE_ACTIVE should be globally visible
    when STRIPE_ACTIVE clears. test_and_set_bit() implies a barrier, but
    clear_bit() does not.

    This is suitable for 3.1-stable.

    Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/md/raid5.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/md/raid5.c
    +++ b/drivers/md/raid5.c
    @@ -3116,7 +3116,7 @@ static void handle_stripe(struct stripe_
    struct r5dev *pdev, *qdev;

    clear_bit(STRIPE_HANDLE, &sh->state);
    - if (test_and_set_bit(STRIPE_ACTIVE, &sh->state)) {
    + if (test_and_set_bit_lock(STRIPE_ACTIVE, &sh->state)) {
    /* already being handled, ensure it gets handled
    * again when current action finishes */
    set_bit(STRIPE_HANDLE, &sh->state);
    @@ -3381,7 +3381,7 @@ finish:

    return_io(s.return_bi);

    - clear_bit(STRIPE_ACTIVE, &sh->state);
    + clear_bit_unlock(STRIPE_ACTIVE, &sh->state);
    }

    static void raid5_activate_delayed(raid5_conf_t *conf)



    \
     
     \ /
      Last update: 2011-11-10 05:07    [W:4.120 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site