lkml.org 
[lkml]   [2011]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[140/262] macvlan/macvtap: Fix unicast between macvtap interfaces in bridge mode
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: David Ward <david.ward@ll.mit.edu>

    [ Upstream commit cb2d0f3e968bff7c6d262aca3e3ab8d4184e69b2 ]

    Packets should always be forwarded to the lowerdev using dev_forward_skb.
    vlan->forward is for packets being forwarded directly to another macvlan/
    macvtap device (used for multicast in bridge mode).

    Reported-and-tested-by: Shlomo Pongratz <shlomop@mellanox.com>
    Signed-off-by: David Ward <david.ward@ll.mit.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/net/macvlan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/macvlan.c
    +++ b/drivers/net/macvlan.c
    @@ -239,7 +239,7 @@ static int macvlan_queue_xmit(struct sk_
    dest = macvlan_hash_lookup(port, eth->h_dest);
    if (dest && dest->mode == MACVLAN_MODE_BRIDGE) {
    /* send to lowerdev first for its network taps */
    - vlan->forward(vlan->lowerdev, skb);
    + dev_forward_skb(vlan->lowerdev, skb);

    return NET_XMIT_SUCCESS;
    }



    \
     
     \ /
      Last update: 2011-11-10 04:37    [W:4.108 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site