Messages in this thread | | | Date | Wed, 09 Nov 2011 16:06:25 -0500 (EST) | Subject | Re: [PATCH] net/usb: Misc. fixes for the LG-VL600 LTE USB modem | From | David Miller <> |
| |
From: Mark Kamichoff <prox@prolixium.com> Date: Wed, 9 Nov 2011 13:57:14 -0500
> For (a), it's my understanding that __constant_htons() should be used > only for initializers and htons() used in other cases, since it handles > checking for constants. I suppose you're right and this is a little > gratuitous, but I wanted to keep things clean. > > As far as (b), sorry! That's an error on my part. I must have been > practicing another coding style at the time. The braces certainly > shouldn't be there, let me know if I should resubmit.
Please get rid of the gratuitous htons() etc. changes and keep this patch purely to the bug fixes and resubmit.
Thank you.
| |