Messages in this thread | | | From | "Voss, Nikolaus" <> | Date | Mon, 7 Nov 2011 11:01:27 +0100 | Subject | RE: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness |
| |
Hi,
> IMHO, you should split this patch into three or more smaller patches. > You're doing lots of different things in one commit and it'll be a pain to > bisect should this cause any issues to anyone.
I didn't split the patch because it is virtually a complete rewrite. Due to the severe limitations of the old driver, I think it should replace the old driver.
> > +/* -*- linux-c -*- > > you shouldn't add this editor hooks to linux source files.
Ok.
> > -static int at91_i2c_resume(struct platform_device *pdev) > > +static int at91_i2c_resume(struct device *dev) > > { > > - return clk_enable(twi_clk); > > + struct platform_device *pdev = to_platform_device(dev); > > + struct at91_i2c_dev *i2c_dev = platform_get_drvdata(pdev); > > dev_get_drvdata(dev) will do the same of two above lines. You don't need to > fetch the platform_device...
Ok.
> > -MODULE_AUTHOR("Rick Bronson"); > > +MODULE_AUTHOR("Nikolaus Voss"); > > wow... are you sure ? Rick will always be the original author, no ?
Yes, of course, but I don't want to declare him responsible for my own mistakes. The new driver has almost nothing to do with the old.
Thanks for your *very* fast reply and review.
Niko
| |