Messages in this thread | | | Date | Mon, 7 Nov 2011 21:26:02 +0800 | From | Yong Zhang <> | Subject | Re: [RFC PATCH 4/4] lockdep: fix race condition in __lock_set_class() |
| |
On Mon, Nov 07, 2011 at 01:30:54PM +0100, Peter Zijlstra wrote: > On Fri, 2011-11-04 at 17:26 +0800, Yong Zhang wrote: > > When someone call lock_set_class() with valid key, nothing > > protect the initializing of 'lockdep_map'; thus could lead > > to flase positive warning from lockdep (such as "key not in > > .data!"). This patch cure that potential issue. > > How? that warning is triggered of the lock_class_key * passed into > lockdep_init_map and is unrelated to the actual content of the > lockdep_map.
Oh, my fault, the false positive warning could be "non-static key".
But seems we should find the right direction for this bug :) Some comments in replies to patch#1.
Thanks, Yong
| |