Messages in this thread | | | Date | Mon, 7 Nov 2011 08:51:00 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/9] staging/comedi/jr3: Convert pci_table entries to PCI_DEVICE (if PCI_ANY_ID is used) |
| |
On Mon, Nov 07, 2011 at 12:53:59AM +0100, Peter Huewe wrote: > This patch converts pci_table entries to use the PCI_DEVICE macro, > if .subvendor and .subdevice are set to PCI_ANY_ID, > and thus improves readablity. > > Since the driver_data field isn't used anywhere we can also drop the > assignments for class, class_mask and driver_data. >
The other reason we can remove them is that C will initialize them to zero by default in this case. So the new code is just shorter to write and doesn't change anything.
regards, dan carpenter
[unhandled content-type:application/pgp-signature] | |