lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 1/5]thp: improve the error code path
From
Date
On Wed, 2011-10-26 at 09:48 +0800, Shaohua Li wrote:
> On Tue, 2011-10-25 at 19:44 +0800, Andrea Arcangeli wrote:
> > Hello,
> >
> > On Tue, Oct 25, 2011 at 10:58:41AM +0800, Shaohua Li wrote:
> > > +#ifdef CONFIG_SYSFS
> > > + sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group);
> > > +remove_hp_group:
> > > + sysfs_remove_group(hugepage_kobj, &hugepage_attr_group);
> > > +delete_obj:
> > > + kobject_put(hugepage_kobj);
> > > out:
> > > +#endif
> >
> > Adding an ifdef is making the code worse, the whole point of having
> > these functions become noops at build time is to avoid having to add
> > ifdefs in the callers.
> yes, but hugepage_attr_group is defined in CONFIG_SYSFS. And the
> functions are inline functions. They really should be a '#define xxx'.
ping, any comments for the 5 patches?



\
 
 \ /
  Last update: 2011-11-07 06:11    [W:0.080 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site