lkml.org 
[lkml]   [2011]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] gpiolib: output basic details and consolidate gpio device drivers
On Sat, Nov 05, 2011 at 10:27:51PM +0100, Hartmut Knaack wrote:
> This patch adds a kernel message, containing GPIO range and device name on successful device registration.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> -------------------------------------------------------------

For next time; the divider between commit text and patch must be
exactly 3 '-' characters long, no more, no less. Otherwise the tools
don't handle it properly.

> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index a971e3d..d919ac6 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1088,6 +1088,10 @@ unlock:
> status = gpiochip_export(chip);
> if (status)
> goto fail;
> +

Whitespace error.

Otherwise looks good. I'm picking it up and squashing it together
with the second patch.

> + pr_info("gpiochip_add: registered GPIOs %d to %d on device: %s\n",
> + chip->base, chip->base + chip->ngpio - 1,
> + chip->label ? : "generic");
>
> return 0;
> fail:
>


\
 
 \ /
  Last update: 2011-11-06 19:35    [W:0.073 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site