lkml.org 
[lkml]   [2011]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] Staging: zram: Turn lockdep off during zram_init_device()
From
Date
On Wed, 2011-11-30 at 14:14 +0100, Jerome Marchand wrote:
> zram->init_lock can be hold over an allocation that may try to reclaim
> memory in zram_init_device(). The same lock can later be taken from a
> reclaim context in zram_make_request(), thus triggering a lockdep
> warning. However, memory can not be reclaimed to an uninitialized zram
> device. Therefore, this warning is a false positive.
> To prevent the warning to occur, we turn lockdep off during while the
> device is initialized.

fuck no! why do you even remotely consider this a sane thing to do?

There's tons of lockdep annotations, try one of those. If you have, your
changelog utterly fails to explain why non of those are suitable and how
your problem is special.




\
 
 \ /
  Last update: 2011-11-30 15:01    [W:0.051 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site