lkml.org 
[lkml]   [2011]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] perf_event: fix loss of notification with multi-event
    From
    Date
    On Sat, 2011-11-26 at 02:47 +0100, Stephane Eranian wrote:
    > Here is a fixed version of Peter's patch.
    > I fixed the compilation errors + added the missing
    > linked list + spinlock initializations.
    >
    > I also added the mmap_mutex in perf_poll() to avoid the
    > race with perf_set_output(). It's not pretty but it solves
    > the problem of a process getting stuck on a sampling buffer
    > which is never going to get any samples. This was an unlikely
    > scenario but we should take care of it anyway.
    >
    > This patch solves the issue with loss of buffer notifications
    > when sampling on multiple events at the same time. In that
    > case fewer than expected samples would be captured.

    Hehe, so it actually works eh.. amazing stuff ;-)

    OK, I'll stick it in perf/urgent.. Thanks Stephane!

    If anybody happens upon a prettier solution, don't be shy and please do
    tell us ;-)




    \
     
     \ /
      Last update: 2011-11-28 11:13    [W:4.562 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site