Messages in this thread | | | Date | Tue, 29 Nov 2011 03:37:08 +0100 | From | Jean-Christophe PLAGNIOL-VILLARD <> | Subject | Re: [PATCH 1/2] gpiolib: introduce gpio_set_pullup |
| |
On 11:35 Sun 27 Nov , Igor Grinberg wrote: > On 11/25/11 17:34, Mark Brown wrote: > > On Fri, Nov 25, 2011 at 03:08:39PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > >> +/** > >> + * gpio_set_pullup - sets @pullup for a @gpio > >> + * @gpio: the gpio to set pullup > >> + * @pullup: pullup level > >> + */ > >> +int gpio_set_pullup(unsigned gpio, unsigned pullup) > > > > This has some overlap with the pinmux subsystem. We also need > > documentation of what the pullup values mean. yes and no
as some gpio IP (only gpio i2c extender as example ) have it too so you can not use the pinmux for this > > +1 > > AFAIK, 3 values are there: up, down and highz > Also, IMO, this should have no effect if the GPIO is configured for output. I see some pio IP have 2 highz
but yes 3 value normaly
Best Regards, J.
| |