Messages in this thread | | | Date | Mon, 28 Nov 2011 19:03:22 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 3/7] ASoC: AD193X: Make enum items const char * const |
| |
On Mon, Nov 28, 2011 at 08:01:38PM +0100, Lars-Peter Clausen wrote: > On 11/28/2011 07:53 PM, Mark Brown wrote: > > On Mon, Nov 28, 2011 at 05:28:08PM +0100, Lars-Peter Clausen wrote:
> >> -static const char *ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"}; > >> +static const char * const ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
> > Ideally this would be converted to a switch and the driver would > > automatically select the rate based on the current sample rate.
> Ideally yes, but I'm not sure if this couldn't break some existing setup if it > expects to find that control.
Well, it might but I'm not sure anyone actually uses deemphasis any more anyway.
| |