Messages in this thread | ![/](/images/icornerl.gif) | | From | H Hartley Sweeten <> | Date | Mon, 28 Nov 2011 11:33:04 -0600 | Subject | RE: [PATCH v2 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to reference an empty list |
| |
On Saturday, November 26, 2011 3:54 AM, Mika Westerberg wrote: > > If dma_terminate_all() is called before the ep93xx_dma_tasklet() gets to run, > it tries to access an empty ->active list which results following OOPS:
[OOPS snipped...]
> To make the code a bit more robust against things like these, we modify > ep93xx_dma_get_active() to return NULL in case of empty ->active list and make > sure that callers handle this correctly. > > Reported-by: Rafal Prylowski <prylowski@metasoft.pl> > Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi> > --- > drivers/dma/ep93xx_dma.c | 60 ++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 48 insertions(+), 12 deletions(-)
Looks good. Thanks.
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
| ![\](/images/icornerr.gif) |