lkml.org 
[lkml]   [2011]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/9] trace: Fix uninitialized variable compiler warning
From
Date
On Sun, 2011-11-27 at 19:04 +0100, Jiri Olsa wrote:
> Initialize page2 variable to make compiler happy.

What compiler is this? Because this is a compiler bug. In fact, there's
no check for page2 being NULL, so if it is used uninitialized it will
crash the kernel. I don't like these "make the compiler shut up" fixes,
because honestly, changes like this hide bugs.

Nacked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> ---
> kernel/trace/trace.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 9e158cc..4a06862 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -3655,8 +3655,7 @@ tracing_mark_write(struct file *filp, const char __user *ubuf,
> struct page *pages[2];
> int nr_pages = 1;
> ssize_t written;
> - void *page1;
> - void *page2;
> + void *page1, *page2 = NULL;
> int offset;
> int size;
> int len;




\
 
 \ /
  Last update: 2011-11-28 17:21    [W:0.602 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site