Messages in this thread | | | Date | Mon, 28 Nov 2011 20:04:40 +0400 | From | Pavel Emelyanov <> | Subject | Re: [PATCH] sysctl: Add the kernel.ns_last_pid control |
| |
On 11/28/2011 07:53 PM, Tejun Heo wrote: > On Mon, Nov 28, 2011 at 07:21:25PM +0400, Pavel Emelyanov wrote: >> +static int pid_ns_ctl_handler(struct ctl_table *table, int write, >> + void __user *buffer, size_t *lenp, loff_t *ppos) >> +{ >> + struct ctl_table tmp = *table; >> + >> + if (write && !capable(CAP_SYS_ADMIN)) >> + return -EPERM; >> + >> + /* >> + * Writing directly to ns' last_pid field is OK, since this field >> + * is volatile in a living namespace anyway and a code writing to >> + * it should synchronize its usage with external means. >> + */ > > I would still prefer using set_last_pid() but if you insist to update > last_pid directly, please note the direct update in the comment on top > of set_last_pid() too.
It's already there in this patch.
> Other than that, > > Acked-by: Tejun Heo <tj@kernel.org>
Thanks!
> Thanks. >
| |