Messages in this thread Patch in this message | | | Subject | [PATCH 2/2] regulator: aat2870: Remove a redundant bitwise and operation | From | Axel Lin <> | Date | Mon, 28 Nov 2011 14:07:48 +0800 |
| |
The implementation in aat2870_update() already did the bitwise and operation against mask parameter.
Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- It was sent on https://lkml.org/lkml/2011/7/5/560 and resent on https://lkml.org/lkml/2011/8/29/210.
Seems the patch is lost so I resend it again. Axel drivers/regulator/aat2870-regulator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c index 43b25cc..685ad43 100644 --- a/drivers/regulator/aat2870-regulator.c +++ b/drivers/regulator/aat2870-regulator.c @@ -63,7 +63,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev, struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent); return aat2870->update(aat2870, ri->voltage_addr, ri->voltage_mask, - (selector << ri->voltage_shift) & ri->voltage_mask); + selector << ri->voltage_shift); } static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev) -- 1.7.5.4
| |