Messages in this thread | | | Subject | Re: [patch 3/7] sched: set skip_clock_update in yield_task_fair() | From | Peter Zijlstra <> | Date | Thu, 24 Nov 2011 11:12:25 +0100 |
| |
On Thu, 2011-11-24 at 04:50 +0100, Mike Galbraith wrote: > On Wed, 2011-11-23 at 15:48 +0100, Peter Zijlstra wrote: > > On Tue, 2011-11-22 at 15:21 +0100, Mike Galbraith wrote: > > > This is another case where we are on our way to schedule(), > > > so can save a useless clock update and resulting microscopic > > > vruntime update. > > > > > > > Everytime I see one of these skip_clock_update thingies I get the idea > > we should do something smarter, because its most fragile and getting it > > wrong results in a subtle trainwreck.. > > > > Would something like the below help in validating this stuff? > > No, because switch itself is irrelevant to fair-beans counting.
Hmm, right, but we can keep another counter that is more relevant, like all schedule(),ttwu() and various other calls, right?
Thing is, is that going to be less fragile than the current crap :-(
| |