lkml.org 
[lkml]   [2011]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 3.2-rc2 5/30] uprobes: copy of the original instruction.
On Wed, 23 Nov 2011 19:40:16 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote:
> > + /* TODO : Analysis and verification of instruction
> > */
>
> As in refuse to set a breakpoint on an instruction we can't deal with?
>
> Do we care? The worst case we'll crash the program, but if we're
> allowed setting uprobes we already have enough privileges to do that
> anyway, right?
>

I think we should and we do care.
That's already implemented in the subsequent patches too.
For example: we don't a trace breakpoint instruction.

--
Thanks and Regards
Srikar



\
 
 \ /
  Last update: 2011-11-24 13:53    [W:0.512 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site