Messages in this thread | | | Subject | Re: softirq oops from b44_poll | From | Peter P Waskiewicz Jr <> | Date | Wed, 23 Nov 2011 00:13:10 -0800 |
| |
On Tue, 2011-11-22 at 12:54 -0800, David Miller wrote: > From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> > Date: Mon, 21 Nov 2011 15:17:33 -0800 > > > I suspect the "right" way to fix this is to call dev_kfree_skb_any(skb); > > instead, since that will handle the in-interrupt case if that's where > > we're stuck. > > Caller is always b44_poll(), and that caller always does spin_lock_irqsave(). > > Adding the extra tests implied by dev_kfree_skb_any() therefore doesn't > make any sense, as it will always evaluate to dev_kfree_skb_irq().
Agreed, I didn't dig enough through the code. Thanks Dave.
-PJ [unhandled content-type:application/x-pkcs7-signature] | |