lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [V3 PATCH 1/2] tmpfs: add fallocate support
On Wed, 23 Nov 2011, Cong Wang wrote:
> +
> + while (index < end) {
> + ret = shmem_getpage(inode, index, &page, SGP_WRITE, NULL);
> + if (ret) {
> + if (ret == -ENOSPC)
> + goto undo;
...
> +undo:
> + while (index > start) {
> + shmem_truncate_page(inode, index);
> + index--;
> + }

As I said before, I won't actually be reviewing and testing this for
a week or two; but before this goes any further, must point out how
wrong it is. Here you'll be deleting any pages in the range that were
already present before the failing fallocate().

Hugh


\
 
 \ /
  Last update: 2011-11-23 20:09    [W:0.078 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site