Messages in this thread | | | Date | Wed, 23 Nov 2011 07:59:52 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2] trace_event_filter: factorize filter creation |
| |
Hello,
On Wed, Nov 23, 2011 at 10:19:21AM -0500, Steven Rostedt wrote: > For such a change, I would have liked to see more deletions than > insertions. Although, if it removes duplicate code, I'm not against such > a change.
Yeah, certainly. If you count out the function comments, it reduces ~30 lines of code. I was trying to add another user and with one more user, the stats become more attractive.
> I'll look at this more when I get some more time. But just in > case I forget about it (because I wont look at it before my turkey > dinner tomorrow, and will most likely forget about it come next Monday), > please feel free to ping me again next week.
Will do so.
Thank you.
-- tejun
| |