Messages in this thread | | | Date | Wed, 23 Nov 2011 07:35:00 +0100 | Subject | Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support | From | Corentin Chary <> |
| |
On Tue, Nov 22, 2011 at 11:23 PM, Greg KH <gregkh@suse.de> wrote: > On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote: >> Signed-off-by: Corentin Chary <corentincj@iksaif.net> > > What happens on boxes that don't have this type of hardware? Will the > LED device still show up, yet it will not work? > > You should be able to trigger this off of the model type somehow, much > like the video backlight should work.
kbd_backlight_enable(samsung) will be called, it will fire a {0x78, 0xaabb} command on machines using swsmi and this command will fail if the feature is not available. I did some test, and unknown commands seems to fail gracefully, and that makes sabi_command() (and callers) return -EINVAL).
It think {0x78, 0x80} is also here to tell if the backlight is available or not, but I can't test it, since it always returns 1 here.
So yeah, if someone could test that on a swsmi laptop without keyboard backlight, that would be great. -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |