Messages in this thread | | | Date | Wed, 23 Nov 2011 16:41:48 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg register on resume |
| |
On 11/23/2011 4:19 PM, Vinod Koul wrote: > then why not perform save and restore in your suspend and restore > callbacks. That way you don't pay penalty of doing that in every alloc > as you seem to be doing now?
Not actually. I am not saving anything to be restored after suspend. There are few things (configuring CFG regs and enabling interrupts), which are done earlier on alloc_channels. As this will not be called after resume, so we need to set them again.
What i have done is, removed all this stuff from alloc channels and moved it to dwc_dostart(). Here, i am checking if channel is already programmed or not. If not (Can happen only in two cases: On resume and other on fresh channel alloc), i configure them. So there is no save/restore actually done.
-- viresh
| |