lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kconfig: Fix checking return value of 'fwrite'
From: Michal Marek <mmarek@suse.cz>
Date: Sun, 20 Nov 2011 14:24:35 +0100
>
> On 7.10.2011 05:29, Arnaud Lacombe wrote:
> > Hi,
> >
> > 2011/10/6 Reinhard Tartler <Reinhard.Tartler@informatik.uni-erlangen.de>:
> >> fwrite indicates '1' written member if a zero-length string is written.
> > you forgot the "Signed-off-by: " part :)
>
> Reinhard, can I assume
>
> Signed-off-by: Reinhard Tartler
> <Reinhard.Tartler@informatik.uni-erlangen.de>
>
> ? The patch is otherwise correct.

I have two reasons to oppose this patch.

1. If 'len' value is zero, there is an issue already and it should be
taken care of _before_ calling fwrite().

2. xfwrite() doesn't fix anything except for the compiler warning. It
assumes this world is perfect and it's definitely not a place to take
care of the zero-length string.

--
Jean Sacren


\
 
 \ /
  Last update: 2011-11-23 06:57    [W:0.056 / U:1.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site