lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] hugetlb: Replace BUG() with BUILD_BUG() for dummy definitions.
On Tue, 22 Nov 2011, David Daney wrote:

> From: David Daney <david.daney@cavium.com>
>
> The file linux/hugetlb.h has many places where dummy symbols were
> defined so that the main source code would contain fewer:
>
> #ifdef CONFIG_HUGETLBFS
>
> or
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>
> If there were any misuse of these symbols, the only symptom would be
> an OOPS at runtime. Change the BUG() to BUILD_BUG() to catch
> any such abuse at compile time instead.
>
> Signed-off-by: David Daney <david.daney@cavium.com>

Acked-by: David Rientjes <rientjes@google.com>

> @@ -186,7 +186,7 @@ static inline void set_file_hugepages(struct file *file)
> #else /* !CONFIG_HUGETLBFS */
>
> #define is_file_hugepages(file) 0
> -#define set_file_hugepages(file) BUG()
> +#define set_file_hugepages(file) BUILD_BUG()
> static inline struct file *hugetlb_file_setup(const char *name, size_t size,
> vm_flags_t acctflag, struct user_struct **user, int creat_flags)
> {

Looks like this symbol can just be removed entirely, it's not referenced
anywhere.


\
 
 \ /
  Last update: 2011-11-23 02:37    [W:3.748 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site