lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc-cmos: fix broken NVRAM bank 2 writing
On Sun, 13 Nov 2011 23:20:31 +0100
Ondrej Zary <linux@rainbow-software.org> wrote:

> Fix writing to NVRAM bank 2 in rtc-cmos driver. It never worked since its
> introduction in 2.6.28 because of a typo.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>
> --- linux-3.1-orig/drivers/rtc/rtc-cmos.c 2011-10-24 09:10:05.000000000 +0200
> +++ linux-3.1/drivers/rtc/rtc-cmos.c 2011-11-08 17:43:29.000000000 +0100
> @@ -164,7 +164,7 @@ static inline unsigned char cmos_read_ba
> static inline void cmos_write_bank2(unsigned char val, unsigned char addr)
> {
> outb(addr, RTC_PORT(2));
> - outb(val, RTC_PORT(2));
> + outb(val, RTC_PORT(3));
> }
>
> #else

Strange. Can you suggest why this bug has lived for so long without anyone
noticing it?


\
 
 \ /
  Last update: 2011-11-23 00:19    [W:0.046 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site