Messages in this thread | | | Date | Tue, 22 Nov 2011 14:16:33 -0800 | From | Greg KH <> | Subject | Re: [PATCH 03/15] samsung-laptop: don't handle backlight if handled by acpi/video |
| |
On Tue, Nov 22, 2011 at 11:02:34PM +0100, Corentin Chary wrote: > samsung-laptop is not at all related to ACPI, but since this interface > is not documented at all, and the driver has to use it at load to > understand how it works on the laptop, I think it's a good idea to > disable it if a better solution is available.
I wish this would work, but on the machine that I had, there was a valid ACPI table for the video device, yet I was told to "ignore it, it doesn't work and use the sabi interface instead", so this patch would break that machine :(
We might want to trigger off of the machine type for this kind of thing, that's the only way I can see this working properly.
So, sorry, I can't approve this patch.
greg k-h
| |