Messages in this thread | | | Date | Mon, 21 Nov 2011 12:16:49 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH 1/5] mm: compaction: Allow compaction to isolate dirty pages |
| |
On 11/18/2011 11:58 AM, Mel Gorman wrote: > Commit [39deaf85: mm: compaction: make isolate_lru_page() filter-aware] > noted that compaction does not migrate dirty or writeback pages and > that is was meaningless to pick the page and re-add it to the LRU list. > > What was missed during review is that asynchronous migration moves > dirty pages if their ->migratepage callback is migrate_page() because > these can be moved without blocking. This potentially impacted > hugepage allocation success rates by a factor depending on how many > dirty pages are in the system. > > This patch partially reverts 39deaf85 to allow migration to isolate > dirty pages again. This increases how much compaction disrupts the > LRU but that is addressed later in the series. > > Signed-off-by: Mel Gorman<mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
| |