lkml.org 
[lkml]   [2011]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 6/6] perf, tools: X86 RDPMC, RDTSC test
From
Date
On Mon, 2011-11-21 at 16:29 +0100, Stephane Eranian wrote:
> Peter,
>
> I don't see how this test and infrastructure handles the case where the event
> is multiplexed. I know there is time_enabled and time_running. But those are
> not sync'd to the moment of the rdpmc(). I think there needs to be some other
> timestamp in the mmap struct so the user can compute a delta to then add to
> time_enabled and time_running.

When the counter isn't actually on the PMU, ->index will be 0 and rdpmc
should not be attempted.

> Unless, we assume the two time metrics are there ONLY to compute a scaling
> ratio. In which case, I think, we don't need the delta because if we
> can do rdpmc()
> it means the event is currently scheduled and thus time_enabled and time_running
> are both ticking which means the scaling ratio does not change since the moment
> the event was scheduled in.

Right, you don't need delta to compute the scale, but its useful for
user-space time based measurements, Arun wanted to do something like
that.



\
 
 \ /
  Last update: 2011-11-21 16:39    [W:0.085 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site