lkml.org 
[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hugetlb: Provide a default HPAGE_SHIFT if !CONFIG_HUGETLB_PAGE
On Wed, 16 Nov 2011, David Daney wrote:

> From: David Daney <david.daney@cavium.com>
>
> This is required now to get MIPS kernels to compile with
> !CONFIG_HUGETLB_PAGE.
>

Why? Apparently there's some config option you've enabled that is causing
it to fail but I can't find it. defconfig works fine on my mips
crosscompiler and allyesconfig is borked already in other ways.

This is definitely the wrong fix, anyway, and it would require a change to
arch/mips/include/asm/page.h instead since it's localized to mips, so
nack.

> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> include/linux/hugetlb.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 19644e0..746d543 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -113,6 +113,7 @@ static inline void copy_huge_page(struct page *dst, struct page *src)
> #ifndef HPAGE_MASK
> #define HPAGE_MASK PAGE_MASK /* Keep the compiler happy */
> #define HPAGE_SIZE PAGE_SIZE
> +#define HPAGE_SHIFT PAGE_SHIFT
> #endif
>
> #endif /* !CONFIG_HUGETLB_PAGE */


\
 
 \ /
  Last update: 2011-11-16 22:35    [W:0.105 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site