Messages in this thread Patch in this message | | | From | Lars-Peter Clausen <> | Subject | [PATCH v2 2/2] regmap: Drop check whether a register is readable in regcache_read | Date | Wed, 16 Nov 2011 20:34:04 +0100 |
| |
One of the reasons for using a cache is to have a software shadow of a register which is writable but not readable. This allows us to do a read-modify-write operation on such a register.
Currently regcache checks whether a register is readable when performing a cached read and returns an error if it is not. Drop this check, since it will prevent us from using the cache for registers where read-back is not possible.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
--- Changes since v1: * Drop the check instead of replaceing it with a check whether the register is writable since this would break once we start adding read-back values to the cache. --- drivers/base/regmap/regcache.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 6d93e49..e21eebd 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -199,9 +199,6 @@ int regcache_read(struct regmap *map, BUG_ON(!map->cache_ops); - if (!regmap_readable(map, reg)) - return -EIO; - if (!regmap_volatile(map, reg)) return map->cache_ops->read(map, reg, value); -- 1.7.7.1
| |