Messages in this thread | | | Date | Wed, 16 Nov 2011 16:24:43 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/7] regmap: Make reg_config reg_defaults const |
| |
On Wed, Nov 16, 2011 at 05:23:33PM +0100, Lars-Peter Clausen wrote: > On 11/16/2011 05:13 PM, Mark Brown wrote:
> > You should've got reams of sparse warnings from that - the indexed cache > > is writing to the defaults table (which is very naughty and i keep > > thinking about deleting it as a result).
> This patch makes reg_defaults const in the reg_config struct not in the > regmap struct.
> Since we duplicate the reg_config reg_defaults into the regmap reg_defaults > the index cache works on a runtime allocated array. (Though I wouldn't > object to see it gone. For the average uscase it uses more memory and is > slower than the rbnode cache).
Did you actually check the sparse output?
| |