lkml.org 
[lkml]   [2011]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ARM: NUC900: add and change some device clk definitions.
Date
On Tuesday 15 November 2011, Wan ZongShun wrote:
> This patch is to modify usb, audio and add i2c clk setting in cpu.c.
> Also, add DMA, FMI definition to nuc900_iodesc, since I will use them
> in the corresponding driver.
>
> ---
> arch/arm/mach-w90x900/cpu.c | 14 +++++++++++---
> 1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
> index 0a235e5..6eeadfc 100644
> --- a/arch/arm/mach-w90x900/cpu.c
> +++ b/arch/arm/mach-w90x900/cpu.c
> @@ -46,6 +46,8 @@ static struct map_desc nuc900_iodesc[] __initdata = {
> IODESC_ENT(TIMER),
> IODESC_ENT(EBI),
> IODESC_ENT(GPIO),
> + IODESC_ENT(DMA),
> + IODESC_ENT(FMI),
> };

Can you change the driver to instead use ioremap with the device resources?
I think that would be much preferred. The two main uses of map_desc are
for devices that you need very early and in order to get larger than 4k
TLB entries. Neither of these seem to apply here.

Arnd


\
 
 \ /
  Last update: 2011-11-15 22:05    [W:1.952 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site