| Date | Mon, 14 Nov 2011 17:39:53 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH v6 3.2-rc1 28/28] uprobes: introduce UTASK_SSTEP_TRAPPED logic |
| |
On 11/11, Srikar Dronamraju wrote: > > +void __weak abort_xol(struct pt_regs *regs, struct uprobe_task *utask) > +{ > + set_instruction_pointer(regs, utask->vaddr); > +}
OK, this is fine on 32bit. But X86_64 should also handle UPROBES_FIX_RIP_AX/CX?
IOW, shouldn't we also do
if (uprobe->fixups & UPROBES_FIX_RIP_AX) regs->ax = tskinfo->saved_scratch_register; else if (uprobe->fixups & UPROBES_FIX_RIP_CX) regs->cx = tskinfo->saved_scratch_register;
on 64bit?
Oleg.
|