lkml.org 
[lkml]   [2011]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] blackfin: Fixup export.h includes
On 11-11-11 05:54 AM, Bob Liu wrote:
> On Fri, Nov 11, 2011 at 6:06 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> Commit 8dc7a9c84 ("blackfin: Add export.h to files using
>> EXPORT_SYMBOL/THIS_MODULE") inserted some of the include statements into
>> sections protected by an unrelated #if CONFIG_... statement. This can cause,
>> depending on the configuration used, warnings like this one:
>>
>> arch/blackfin/mach-bf537/boards/stamp.c:2940: warning: data definition has no type or storage class
>> arch/blackfin/mach-bf537/boards/stamp.c:2940: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL’
>> arch/blackfin/mach-bf537/boards/stamp.c:2940: warning: parameter names (without types) in function declaration
>>
>> This patch fixes it by moving the includes out of the #if protected sections.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

[...]

>>
>
> Thanks! I'll pick it.
>
> Acked-by: Bob Liu <lliubbo@gmail.com>

Looks fine to me as well. I'm assuming it will make it in
tree via Bob, as per above.

Thanks,
Paul.

>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-11-11 16:57    [W:0.034 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site