Messages in this thread | | | Date | Fri, 7 Oct 2011 18:58:28 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v5 3.1.0-rc4-tip 26/26] uprobes: queue signals while thread is singlestepping. |
| |
On 10/06, Srikar Dronamraju wrote: > > The patch (that I sent out as part of v5 patchset) uses per task > pending sigqueue and start queueing the signals when the task > singlesteps. After completion of singlestep, walks thro the pending > signals.
Yes, I see. Doesn't look very nice ;)
> But I was thinking if I should block signals instead of queueing them in > a different sigqueue. So Idea is to block signals just before the task > enables singlestep and unblock after task disables singlestep.
Agreed, this looks much, much better. In both cases the task is current, it is safe to change ->blocked.
But please avoid sigprocmask(), we have set_current_blocked().
Oleg.
| |