Messages in this thread | | | Date | Mon, 31 Oct 2011 11:02:49 +0200 | From | Peter De Schrijver <> | Subject | Re: [PATCH 2/6] arm/tegra: prepare pinmux code for multiple tegra variants |
| |
On Fri, Oct 28, 2011 at 06:18:27PM +0200, Stephen Warren wrote: > Peter De Schrijver wrote at Friday, October 28, 2011 2:18 AM: > > On Thu, Oct 27, 2011 at 09:59:49PM +0200, Stephen Warren wrote: > > > Peter De Schrijver wrote at Tuesday, October 25, 2011 10:54 AM: > > > > This patch modifies the pinmux code to be useable for multiple tegra variants. > > > > Some tegra20 specific constants will be replaced by variables which will be > > > > initialized to the appropriate value at runtime. > ... > > > > @@ -668,11 +668,24 @@ void tegra_pinmux_config_pullupdown_table(const struct tegra_pingroup_config *co > > > > } > > > > } > > > > > > > > +static struct of_device_id tegra_pinmux_of_match[] __devinitdata = { > > > > + { .compatible = "nvidia,tegra20-pinmux", tegra20_pinmux_init }, > > > > + { }, > > > > +}; > > > > + > > > > static int __devinit tegra_pinmux_probe(struct platform_device *pdev) > > > > { > > > > struct resource *res; > > > > int i; > > > > int config_bad = 0; > > > > + const struct of_device_id *match; > > > > + > > > > +#ifdef CONFIG_OF > > > > + match = of_match_device(tegra_pinmux_of_match, &pdev->dev); > > > > > > What if match==NULL? I suppose that "can't" happen with DT, since the > > > device wouldn't have been probed unless there was a matching entry... > > > > Exactly. That was my reasoning as well. We can't get here unless there is a > > match. > > > > > Does this work when booting without DT; IIRC the internal patches I saw > > > fell back to hard-coding a call to tegra20_pinmux_init() when booting > > > a static board file (i.e. not booting device-tree)? Perhaps that's in a > >
Indeed. Something went wrong here.
> > Unfortunately I don't have a tegra20 board which is supported without > > devicetree. > > Oh, that's quite unfortunate. Still, you need to write the code so it's > expected to work for the non-DT case. Once you've fixed this, if you > push a complete branch somewhere, I can boot-test it on a few non-DT > boards. Hopefully I can test on Cardhu too.
I know. But alas I have to base myself on assumptions, which is suboptimal of course. I will see if I can find a tegra20 board which doesn't require devicetree here in finland or push a complete branch somewhere.
Cheers,
Peter.
| |