lkml.org 
[lkml]   [2011]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/13] block, cfq: unlink cfq_io_context's immediately
Hello,

On Wed, Oct 26, 2011 at 03:48:57PM -0400, Vivek Goyal wrote:
> > + ioc_release_depth_inc(cic->q);
> > + cic->exit(cic);
> > + cic->release(cic);
> > + ioc_release_depth_dec(cic->q);
>
> cic->release(cic) can free the cic? Are we accessing cic after freeing it
> up in ioc_release_depth_dec(cic->q);

As cic is RCU freed and we're running w/ irq disabled, this shouldn't
blow up, but yeah, I'll update it to use local variable instead.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-10-26 21:57    [W:0.074 / U:1.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site