Messages in this thread | | | Date | Mon, 24 Oct 2011 15:49:30 +0200 | From | Mark Brown <> | Subject | Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data |
| |
On Mon, Oct 24, 2011 at 09:40:26PM +0800, Shawn Guo wrote:
> +++ b/drivers/regulator/core.c > @@ -2673,7 +2673,8 @@ struct regulator_dev *regulator_register(struct regulator_desc *regulator_desc, > BLOCKING_INIT_NOTIFIER_HEAD(&rdev->notifier); > > /* find device_node and attach it */ > - rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name); > + rdev->dev.of_node = of_find_node_by_name(dev->parent->of_node, > + regulator_desc->name); >
Is that going to do the right thing if you've got a MFD which does register each regulator as a separate device? Might be best to just search within dev and get drivers to pass the "real" device in when registering the regulator rather than the virtual device.
| |