Messages in this thread | | | Date | Mon, 24 Oct 2011 16:30:46 +0530 | From | Raghavendra K T <> | Subject | Re: [PATCH RFC V2 3/5] kvm hypervisor : Add two hypercalls to support pv-ticketlock |
| |
On 10/24/2011 03:31 PM, Sasha Levin wrote: > On Mon, 2011-10-24 at 00:35 +0530, Raghavendra K T wrote: >> Add two hypercalls to KVM hypervisor to support pv-ticketlocks. >> >> +static void kvm_pv_kick_cpu_op(struct kvm *kvm, int cpu) >> +{ >> + struct kvm_vcpu *vcpu = kvm_get_vcpu(kvm, cpu); >> + >> + if (vcpu) { >> + vcpu->kicked = 1; > > I'm not sure about it, but maybe we want a memory barrier over here?
Yes, Thanks for pointing this. Avi Kivity also pointed same. 'll add barrier() here.
> >> + wake_up_interruptible(&vcpu->wq); >> + } >> +}
| |