lkml.org 
[lkml]   [2011]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Driver for Primax keyboards violating USB HID spec
On Thu, 13 Oct 2011, Terry Lambert wrote:

> Hi Jiri; thanks for looking so promptly!
>
> The routine right now just caches the hi->input for later look up
> during the raw input report, which I suppose could be done inline on
> each report with a couple function calls.

Well yes, but even in px_raw_event() the px_device *px is only
initialized, but never used. So I'd just remove the whole px_device thing
altogether, I don't think it's needed.

> I don't have one of the folding keyboards people are complaining about
> not being able to use for Android tablets on hand, or the unhappy Dell
> Inspiron laptop, both of which use the controller  That's to explain
> why the remapping code and the product ID for them are missing from
> this patch.

I see.

I'd like to ask you though to only submit patches containing code that is
actually used. Whenever the remapping part is needed for some other
keyboard, we'll just add it at the very time it's needed.

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-10-14 11:33    [W:0.037 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site