Messages in this thread | | | Date | Thu, 13 Oct 2011 12:30:45 -0600 (MDT) | From | Paul Walmsley <> | Subject | Re: [PATCH 2/5 v14] arm: omap: usb: ehci and ohci hwmod structures for omap3 |
| |
On Tue, 11 Oct 2011, Keshava Munegowda wrote:
> Following 2 hwmod structures are added > 1. usb_host_hs > The hwmod of usbhs with uhh, ehci and ohci base addresses > functional clock and ehci, ohci irqs > > 2. usb_tll_hs > hwmod of usbhs with the TLL base address and irq. > > Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> > Reviewed-by: Partha Basak <parthab@india.ti.com> > --- > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 230 ++++++++++++++++++++++++++++ > 1 files changed, 230 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > index 59fdb9f..c06b4a4 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > @@ -84,6 +84,8 @@ static struct omap_hwmod omap3xxx_mcbsp4_hwmod;
...
> +static struct omap_hwmod_ocp_if omap34xx_ick_cfg__usb_tll_hs = { > + .clk = "usbtll_ick", > + .addr = omap34xx_usb_tll_hs_addrs, > + .user = OCP_USER_MPU | OCP_USER_SDMA, > +};
This version doesn't respond to my previous comment:
"This interface is missing a .master and .slave. It must have both. So, dropping this patch until it's fixed."
Insert boilerplate frustration here...
- Paul
| |