Messages in this thread | | | Date | Tue, 11 Oct 2011 10:01:54 +0200 | From | "Cousson, Benoit" <> | Subject | Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4 |
| |
Hi Paul,
On 10/11/2011 2:40 AM, Paul Walmsley wrote: > Hi > > and some comments on this one ... > > On Thu, 6 Oct 2011, Keshava Munegowda wrote:
[...]
>> +static struct omap_hwmod_ocp_if omap44xx_l4_cfg__usb_tll_hs = { >> + .master =&omap44xx_l4_cfg_hwmod, >> + .slave =&omap44xx_usb_tll_hs_hwmod, >> + .addr = omap44xx_usb_tll_hs_addrs, >> + .user = OCP_USER_MPU | OCP_USER_SDMA, >> +}; > > This one has the .master pointing to something reasonable, but is missing > a .clk entry.
In that case, there is only an interface clock and a couple of optional clocks, that why I did not populate the main_clk.
IIRC, we decided to not duplicate the iclk into the main_clk in case of module that are using only the interface clock as their functional clock.
Regards, Benoit
| |