Messages in this thread | | | Date | Mon, 10 Oct 2011 19:47:36 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 0/6] udf: Change some KERN_<level>s and logging neatening |
| |
On Mon 10-10-11 01:08:01, Joe Perches wrote: > I reviewed your patch and think it's too large > for others to review because it combines multiple > things into a single patch. > > I think that adding struct super_block * to udb_debug > isn't necessary or particularly useful. > > Here are the changes to your original patch that I made: > > Separate a single large patch into reviewable chunks. > Don't convert every message type to udf_<foo>. > > Joe Perches (6): > udf: Promote some debugging messages to udf_error > udf: Rename udf_error to udf_err > udf: Rename udf_warn to udf_warn > udf: Convert printks to pr_<level> > udf: Neaten logging output, use vsprintf extension %pV > udf: Neaten udf_debug uses So, I've merged all the patches (patches 1, 4, and 5 with some modifications). Since kernel.org where I normally have my tree is down (well, better said I have not reestablished my tree there yet), I'll resend the whole series in a while so that people see what I carry.
Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |