lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] cgroup: always lock threadgroup during migration
On Sun, Sep 18, 2011 at 07:41:17PM +0200, Oleg Nesterov wrote:
> On 09/05, Tejun Heo wrote:
> >
> > * Remove -ESRCH failure path from cgroup_task_migrate(). With the
> > above changes, it's guaranteed to be called only for live tasks.
>
> I think you can remove another similar check,
>
> > @@ -2044,6 +2044,10 @@ int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader)
> > tsk = leader;
> > i = 0;
> > do {
> > + /* @tsk either already exited or can't exit until the end */
> > + if (tsk->flags & PF_EXITING)
> > + continue;
> > +
> > /* as per above, nr_threads may decrease, but not increase. */
> > BUG_ON(i >= group_size);
> > get_task_struct(tsk);
>
> And then cgroup_attach_proc() does
>
> for (i = 0; i < group_size; i++) {
> ...
> task_lock(tsk);
> if (tsk->flags & PF_EXITING) {
> task_unlock(tsk);
> continue;
>
> Afaics, this is no longer needed.

Indeed, removed.

Thank you.

--
tejun


\
 
 \ /
  Last update: 2011-10-10 19:33    [W:0.045 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site